fix: deterministic time parsing #751
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Description
This PR make time parsing deterministic and explicitly validated. This will make accept only unambiguous formats, reject ambigous and engine-dependent strings and guard against accidnetal coercions from non-string inputs.
Dateobjects are always tricky to handle. It wouldn't be a big problem if we weren't receiving user input directly like we are now, but we'll never know what might happen later. (ref: https://jsdate.wtf/)For example, the previous function implicitly trusted those strings and delegated parsing to the JS engine. That means:
2023-02-29rolling over to March 1)...
Changes
Parsing Policy (normalized)
Accepted inputs
Zor explicit offset(±HH:MM)YYYY-MM-DD) -> interpreted as UTC midnight viaDate.UTCto avoiding timezone driftgetTime()(already UTC epoch ms)Rejected inputs